Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] base_report_to_label_printer: Migration to 18.0 #1

Open
wants to merge 11 commits into
base: 18.0
Choose a base branch
from

Conversation

Kimkhoi3010
Copy link
Owner

@api.model
def _register_hook(self):
super()._register_hook()
self.SELF_WRITEABLE_FIELDS.extend(["default_label_printer_id"])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comodel_name="printing.printer", string="Default Label Printer"
)

@api.model
Copy link

@xaviedoanhduy xaviedoanhduy Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@api.model

no need override this method

@xaviedoanhduy
Copy link

btw, can you squash the commit in the next update?

@Kimkhoi3010 Kimkhoi3010 force-pushed the 18.0-mig-base_report_to_label_printer branch from 250269a to 94219bb Compare October 16, 2024 03:20
Copy link

@xaviedoanhduy xaviedoanhduy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code review)

@nilshamerlinck
Copy link

test-requirements.txt content looks odd, please check again

@Kimkhoi3010 Kimkhoi3010 force-pushed the 18.0-mig-base_report_to_label_printer branch 2 times, most recently from dc3e56e to 670a304 Compare October 22, 2024 07:50
@Kimkhoi3010 Kimkhoi3010 force-pushed the 18.0-mig-base_report_to_label_printer branch from 670a304 to c9d8629 Compare October 22, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants